BCEL6: avoid exceptions on INVOKEDYNAMIC instructions, see findbugspr…

…oject#106 Created TODO's in the code to avoid analysis errors while visiting INVOKEDYNAMIC instructions.
sebasjm · Jun 8, 2016 · 070c1f3 · 070c1f3
1 parent b6bcb26
commit 070c1f3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/findbugs/src/java/edu/umd/cs/findbugs/ba/Hierarchy2.java b/findbugs/src/java/edu/umd/cs/findbugs/ba/Hierarchy2.java
@@ -312,6 +312,11 @@ Set<XMethod> resolveMethodCallTargets(InvokeInstruction invokeInstruction, TypeF
             return Collections.<XMethod> emptySet();
         }
 
+        // XXX handle INVOKEDYNAMIC
+        if (opcode == Constants.INVOKEDYNAMIC) {
+            return Collections.<XMethod> emptySet();
+        }
+
         Type receiverType;
         boolean receiverTypeIsExact;
 

diff --git a/findbugs/src/java/edu/umd/cs/findbugs/ba/jsr305/Analysis.java b/findbugs/src/java/edu/umd/cs/findbugs/ba/jsr305/Analysis.java
@@ -27,6 +27,7 @@
 import javax.annotation.meta.When;
 
 import org.apache.bcel.generic.ConstantPoolGen;
+import org.apache.bcel.generic.INVOKEDYNAMIC;
 import org.apache.bcel.generic.Instruction;
 import org.apache.bcel.generic.InvokeInstruction;
 
@@ -105,8 +106,12 @@ public static Collection<TypeQualifierValue<?>> getRelevantTypeQualifiers(Method
                 Location location = i.next();
                 Instruction ins = location.getHandle().getInstruction();
                 if (ins instanceof InvokeInstruction) {
-                    XMethod called = XFactory.createXMethod((InvokeInstruction) ins, cpg);
-                    addEffectiveRelevantQualifiers(result, called);
+                    if (ins instanceof INVOKEDYNAMIC) {
+                        // TODO handle INVOKEDYNAMIC
+                    } else {
+                        XMethod called = XFactory.createXMethod((InvokeInstruction) ins, cpg);
+                        addEffectiveRelevantQualifiers(result, called);
+                    }
                 }
 
                 if (DEBUG_FIND_EFFECTIVE_RELEVANT_QUALIFIERS) {