Avoid using the Reflection API for some classes #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a class has problems with Reflection, then fall back to the old toArray method of counting its properties. For example, using reflection on an ext-protobuf Message causes a segfault
sebastianbergmann
changed the title
|
Merged manually, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since sebastian/exporter 6.0.3, my tests started to cause a segfault. I tracked this down to cb81155 which uses Reflection to count an object's properties. Some of my tests use a data provider which contains protobuf messages, and somewhere in phpunit's test setup, it triggers this code on the dataProvider's provided data.
Unfortunately using reflection on some parts of ext-protobuf cause a segfault (which can easily be replicated outside of phpunit). It's a long-standing issue in ext-protobuf, and I think it's a "won't fix".
So, I am hoping that by avoiding reflection only on known bad classes, we can still have the performance benefits without the exploding tests :)