optimize empty checks in TestSuite

sebastianbergmann · Jun 20, 2024 · 3a664ca · 3a664ca
1 parent 933af56
commit 3a664ca
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/Framework/TestSuite.php b/src/Framework/TestSuite.php
@@ -137,7 +137,7 @@ public static function fromClassReflector(ReflectionClass $class): static
             $testSuite->addTestMethod($class, $method);
         }
 
-        if (count($testSuite) === 0) {
+        if ($testSuite->isEmpty()) {
             Event\Facade::emitter()->testRunnerTriggeredWarning(
                 sprintf(
                     'No tests found in class "%s".',
@@ -290,7 +290,13 @@ public function count(): int
 
     public function isEmpty(): bool
     {
-        return empty($this->tests);
+        foreach ($this as $test) {
+            if (count($test) !== 0) {
+                return false;
+            }
+        }
+
+        return true;
     }
 
     /**
@@ -337,7 +343,7 @@ public function run(): void
 
         $this->wasRun = true;
 
-        if (count($this) === 0) {
+        if ($this->isEmpty()) {
             return;
         }
 
@@ -362,7 +368,7 @@ public function run(): void
         $this->tests  = [];
         $this->groups = [];
 
-        while (($test = array_pop($tests)) !== false) {
+        while (($test = array_pop($tests)) !== null) {
             if (TestResultFacade::shouldStop()) {
                 $emitter->testRunnerExecutionAborted();