Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestCase::expectNotToPerformAssertions #3042

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

keradus
Copy link
Contributor

@keradus keradus commented Mar 15, 2018

replaces #2898

@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #3042 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3042      +/-   ##
============================================
+ Coverage     80.76%   80.77%   +<.01%     
- Complexity     2879     2880       +1     
============================================
  Files           108      108              
  Lines          7539     7541       +2     
============================================
+ Hits           6089     6091       +2     
  Misses         1450     1450
Impacted Files Coverage Δ Complexity Δ
src/Framework/TestCase.php 66.41% <100%> (+0.08%) 305 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bca1e7...431475e. Read the comment docs.

@sebastianbergmann sebastianbergmann added this to the PHPUnit 7.2 milestone Apr 7, 2018
@sebastianbergmann
Copy link
Owner

@keradus @localheinz Sorry for dropping the ball on this. Is this ready to be merged? Thanks!

@sebastianbergmann sebastianbergmann added the type/enhancement A new idea that should be implemented label Apr 17, 2018
@localheinz
Copy link
Collaborator

@sebastianbergmann

I think it looks good, how about you, @keradus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A new idea that should be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants