Allow empty <extensions> element in XML configuration
#5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 9.6 #5419 +/- ##
=========================================
Coverage 83.16% 83.16%
Complexity 4621 4621
=========================================
Files 271 271
Lines 13682 13682
=========================================
Hits 11379 11379
Misses 2303 2303 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please change your PR to only allow empty
PHPUnit 8.5 is closed for changes that are not required to maintain compatibility with future PHP versions. |
nicolas-grekas
force-pushed
the
xsd-minOccurs
branch
from
2f6bd75
to
43e55c6
Compare
|
PR updated, got it for 8.5! |
sebastianbergmann
changed the title
<extensions> element in XML configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfony, we'd like to have new projects start with a
phpunit.xml.distfile that contains an empty<extensions>tag, see symfony/recipes#1215 for a bit of context. TL;DR, this empty tag would be a very useful hooks for automatically enabling extensions when they're installed with flex.Many tags already have thisminOccurs="0"so I added it to the few tags that don't. Might be useful for similar reasons.I hope this change can make it as a bug fix 🙏 (let me know if I should/can target 8.5 instead)