Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro-optimize NamePrettifier::prettifyTestMethodName() once again #5750

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 14, 2024

the rtrim variant is twice as fast on newer php versions, see php/php-src#13710 (comment)

@staabm staabm marked this pull request as ready for review March 14, 2024 19:21
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (729330a) to head (e252592).

Additional details and impacted files
@@            Coverage Diff            @@
##               10.5    #5750   +/-   ##
=========================================
  Coverage     90.09%   90.09%           
  Complexity     6439     6439           
=========================================
  Files           680      680           
  Lines         19539    19540    +1     
=========================================
+ Hits          17604    17605    +1     
  Misses         1935     1935           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann added feature/testdox The TextDox printer/formatter type/performance Issues related to resource consumption (time and memory) labels Mar 15, 2024
@sebastianbergmann sebastianbergmann changed the title Micro optimize NamePrettifier->prettifyTestMethodName() once again Micro-optimize NamePrettifier::prettifyTestMethodName() once again Mar 15, 2024
@sebastianbergmann sebastianbergmann merged commit 9e89be8 into sebastianbergmann:10.5 Mar 15, 2024
31 checks passed
@staabm staabm deleted the faster-pretty branch March 15, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/testdox The TextDox printer/formatter type/performance Issues related to resource consumption (time and memory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants