Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shortenedRecursiveExport() for data-providers #5774

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 28, 2024

I just realized we already have a shortenedRecursiveExport version of the exporter, we just need to use

so instead of sebastianbergmann/exporter#55 we could just do this single line change

tested this change on roave/BetterReflection:

phpunit 11.0.8

Time: 01:21.576, Memory: 3.79 GB

OK, but some tests were skipped!
Tests: 10383, Assertions: 65007, Skipped: 7.

this PR:

Time: 00:20.042, Memory: 1.04 GB

OK, but some tests were skipped!
Tests: 10383, Assertions: 65007, Skipped: 7.

maybe I did not yet understand that you actually try to make this type of exporter configurable via #5773 ?

@staabm staabm marked this pull request as ready for review March 28, 2024 13:46
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (1b5b302) to head (92227b5).
Report is 701 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5774   +/-   ##
=========================================
  Coverage     92.42%   92.42%           
  Complexity     6557     6557           
=========================================
  Files           699      699           
  Lines         19767    19768    +1     
=========================================
+ Hits          18270    18271    +1     
  Misses         1497     1497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@staabm
Copy link
Contributor Author

staabm commented Apr 5, 2024

@sebastianbergmann does this PR depend on the exporter object PR or can it land independently for 11.x ?

@sebastianbergmann
Copy link
Owner

Not completely exporting data provided by data providers is a BC break and should be opt-in. I am still not sure, though, what the right course of action is here "in the big picture". I hope to find time soon to think about this.

@staabm
Copy link
Contributor Author

staabm commented Jun 17, 2024

btw: I am cooking up a alternative to this PR which consists of a fix in the exporter instead

@staabm
Copy link
Contributor Author

staabm commented Jun 17, 2024

@sebastianbergmann I just saw you rebased this PR. do you have any new insights to share?

@sebastianbergmann
Copy link
Owner

@sebastianbergmann I just saw you rebased this PR. do you have any new insights to share?

I just noticed it's out-of-date and updated it.

@staabm
Copy link
Contributor Author

staabm commented Jun 17, 2024

I see thanks. if we are still at a point in which we don't know whether this PR here is acceptable, it might make sense to instead look more into things similar to sebastianbergmann/exporter#55

(so looking into ways to shorten the export, when a shortenedRecursiveExport is requested)

e.g. sebastianbergmann/exporter#59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants