Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestDox result collector does not correctly handle baseline-ignored E_DEPRECATED issues #5977

Closed

Conversation

pcf0
Copy link
Contributor

@pcf0 pcf0 commented Oct 5, 2024

When comparing versions 11.3.6...11.4.0, I noticed the change from commit f36e89b.
I think in the method testTriggeredPhpDeprecation the wrong line was deleted?

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.68%. Comparing base (9a0bf6c) to head (66a54d2).
Report is 5 commits behind head on 11.4.

Files with missing lines Patch % Lines
...Logging/TestDox/TestResult/TestResultCollector.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               11.4    #5977   +/-   ##
=========================================
  Coverage     94.68%   94.68%           
  Complexity     6762     6762           
=========================================
  Files           713      713           
  Lines         20396    20396           
=========================================
  Hits          19312    19312           
  Misses         1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann force-pushed the testTriggeredPhpDeprecation branch from 0a3e4ae to 66a54d2 Compare October 6, 2024 06:21
@sebastianbergmann sebastianbergmann changed the title Fix baseline check for testTriggeredPhpDeprecation TestDox result collector does not correctly handle baseline-ignored E_DEPRECATED issues Oct 6, 2024
@sebastianbergmann
Copy link
Owner

Cherry-picked into 11.4 and merged to main from there (after adding test cases). Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants