Revert "Fixed ObjectType to be assignable from the PHP "object" type"

This reverts commit 917ac8d.
sebastianbergmann · Jun 19, 2019 · d2b10e3 · d2b10e3
1 parent b2a7f9a
commit d2b10e3
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 59 deletions.
diff --git a/src/ObjectType.php b/src/ObjectType.php
@@ -41,10 +41,6 @@ public function isAssignable(Type $other): bool
             if (\is_subclass_of($other->className->getQualifiedName(), $this->className->getQualifiedName(), true)) {
                 return true;
             }
-
-            if ($other->className->getQualifiedName() === 'object') {
-                return true;
-            }
         }
 
         return false;

diff --git a/tests/unit/ObjectTypeTest.php b/tests/unit/ObjectTypeTest.php
@@ -119,59 +119,4 @@ public function testPreservesNullAllowed(): void
 
         $this->assertTrue($someClass->allowsNull());
     }
-
-    public function testObjectTypeIsAssignableToObjects(): void
-    {
-        $objectType = new ObjectType(
-            TypeName::fromQualifiedName('object'),
-            true
-        );
-
-        $someObject = new class() {
-        };
-
-        $this->assertTrue(Type::fromValue($someObject, false)->isAssignable($objectType));
-    }
-
-    public function testObjectTypeIsNotAssignableToNonObjects(): void
-    {
-        $objectType = new ObjectType(
-            TypeName::fromQualifiedName('object'),
-            true
-        );
-
-        $someNonObject = 123;
-
-        $this->assertFalse(Type::fromValue($someNonObject, false)->isAssignable($objectType));
-    }
-
-    public function testReturnTypeDeclarationIsGeneratedCorrectly(): void
-    {
-        $objectType = new ObjectType(
-            TypeName::fromQualifiedName('object'),
-            false
-        );
-
-        $this->assertSame(': object', $objectType->getReturnTypeDeclaration());
-    }
-
-    public function testNullableReturnTypeDeclarationIsGeneratedCorrectly(): void
-    {
-        $objectType = new ObjectType(
-            TypeName::fromQualifiedName('object'),
-            true
-        );
-
-        $this->assertSame(': ?object', $objectType->getReturnTypeDeclaration());
-    }
-
-    public function testHasClassName(): void
-    {
-        $someClass = new ObjectType(
-            TypeName::fromQualifiedName(ParentClass::class),
-            false
-        );
-
-        $this->assertSame(ParentClass::class, $someClass->className()->getQualifiedName());
-    }
 }