Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ObjectType to be assignable from the PHP "object" type #1

Merged
merged 1 commit into from
May 26, 2019

Conversation

davidbyoung
Copy link
Contributor

This should fix the issue raised here. Basically, this allows object types to be assignable from object. Before, we were only checking if the object was the same class or a subclass of the type you're trying to assign to.

@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #1 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #1      +/-   ##
============================================
+ Coverage     98.23%   98.26%   +0.03%     
- Complexity       63       64       +1     
============================================
  Files             7        7              
  Lines           113      115       +2     
============================================
+ Hits            111      113       +2     
  Misses            2        2
Impacted Files Coverage Δ Complexity Δ
src/ObjectType.php 88.88% <100%> (+1.38%) 11 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a857fc8...5868b13. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #1 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #1      +/-   ##
============================================
+ Coverage     98.23%   98.26%   +0.03%     
- Complexity       63       64       +1     
============================================
  Files             7        7              
  Lines           113      115       +2     
============================================
+ Hits            111      113       +2     
  Misses            2        2
Impacted Files Coverage Δ Complexity Δ
src/ObjectType.php 88.88% <100%> (+1.38%) 11 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a857fc8...5868b13. Read the comment docs.

@sebastianbergmann
Copy link
Owner

CC @MichelHartmann

@sebastianbergmann sebastianbergmann added the bug Something isn't working label May 25, 2019
@sebastianbergmann sebastianbergmann merged commit 917ac8d into sebastianbergmann:master May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants