Skip to content

Commit

Permalink
Fix Removing Request Install Permissions (Catrobat#4645)
Browse files Browse the repository at this point in the history
REQUEST_INSTALL_PACKAGES was used to install standalone APKs. This feature has been disabled due to security concerns, so REQUEST_INSTALL_PACKAGES is not needed anymore.

However, the The REQUEST_INSTALL_PACKAGES permission removal apparently was then ignored. The permission was no longer in our manifest, but if you looked at the apk using Android Studio apk analyzer, it still was there. Apparently it is added in the manifest merge step because of some library we have in it. Figuring out which one it is is not so easy, so we now explicitly state in the manifest that the permission must not be included.

Co-authored-by: Wolfgang Slany <1747888+wslany@users.noreply.github.com>
Co-authored-by: Julia <j.herold@student.tugraz.at>
  • Loading branch information
3 people authored and sebastiangollob committed Nov 5, 2022
1 parent 420b634 commit 599202a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion catroid/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
<uses-permission android:name="android.permission.RECORD_AUDIO" />
<uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" />
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" />

<uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" tools:node="remove" />

<uses-feature
android:name="android.hardware.camera2"
android:required="false" />
Expand Down

0 comments on commit 599202a

Please sign in to comment.