Fix wrong spacing on homepage in Chrome

Fix #95
sebastienbarbier · Oct 3, 2023 · 0298db2 · 0298db2
1 parent abb18a0
commit 0298db2
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,7 @@ See for sample https://raw.githubusercontent.com/favoloso/conventional-changelog
 ## [2.2.2] - 2023-10-03
 ### 🐛 Bug Fixes
 - Fix wrong description within resume (#94) 
+- Fix wrong spacing on homepage in Chrome (#95)
 
 ## [2.2.1] - 2023-09-27
 ### 🛠 Improvements

diff --git a/src/app/home/home.component.scss b/src/app/home/home.component.scss
@@ -6,8 +6,8 @@ header {
   align-items: align-items;
   justify-content: center;
 
-  min-height: 100vh;
-  min-height: -webkit-fill-available;
+  height: 100vh;
+  max-height: -webkit-fill-available;
 
   @include for-tablet-landscape-down {
     justify-content: flex-end;

diff --git a/src/assets/scss/_fonts.scss b/src/assets/scss/_fonts.scss
@@ -231,7 +231,6 @@
   font-display: swap;
 }
 
-
 @font-face {
   font-family: "Source Serif Variable";
   src: url("../fonts/SourceSerif4/SourceSerif4-VariableFont_opsz,wght.ttf") format("truetype-variations");

diff --git a/src/assets/scss/_variables.scss b/src/assets/scss/_variables.scss
@@ -34,7 +34,7 @@ $zindex_navigation: 100;
   font-family: 'Open Sans', Helvetica, sans-serif;
   // If browser support variableFonts, use it
   @supports (font-variation-settings: "wdth" 115) {
-    font-family: 'Open Sans Variable', Helvetica, sans-serif;
+    font-family: 'Open Sans Variable', 'Open Sans', Helvetica, sans-serif;
   }
 }
 
@@ -43,7 +43,7 @@ $zindex_navigation: 100;
   font-variation-settings: 'opsz' 24;
   // If browser support variableFonts, use it
   @supports (font-variation-settings: "wdth" 115) {
-    font-family: 'Source Serif Variable', Arial, serif;
+    font-family: 'Source Serif Variable', 'Source Serif', Arial, serif;
   }
 }