Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize for new parlot features #724

Merged
merged 6 commits into from
Dec 1, 2024
Merged

Optimize for new parlot features #724

merged 6 commits into from
Dec 1, 2024

Conversation

sebastienros
Copy link
Owner

No description provided.

@sebastienros sebastienros merged commit c6d92c8 into main Dec 1, 2024
1 check passed
@sebastienros sebastienros deleted the sebros/optimize branch December 1, 2024 00:10
@sebastienros
Copy link
Owner Author

All this work and now it's slower

before 

| Method         | Mean       | Error     | StdDev    | Gen0   | Allocated |
|--------------- |-----------:|----------:|----------:|-------:|----------:|
| Parse          |   3.505 us | 0.0256 us | 0.0239 us | 0.1717 |   2.83 KB |
| ParseBig       |  15.461 us | 0.0496 us | 0.0464 us | 0.7019 |  11.66 KB |
| ParseAndRender | 243.217 us | 0.5577 us | 0.4354 us | 5.8594 |  99.21 KB |

after

| Method         | Mean       | Error     | StdDev    | Gen0   | Allocated |
|--------------- |-----------:|----------:|----------:|-------:|----------:|
| Parse          |   3.914 us | 0.0280 us | 0.0262 us | 0.1678 |   2.84 KB |
| ParseBig       |  17.155 us | 0.0414 us | 0.0346 us | 0.7019 |  11.67 KB |
| ParseAndRender | 247.994 us | 0.7497 us | 0.7012 us | 5.8594 |  99.23 KB |

Will try to isolate what regressed in Parlot, or if this because of these changes here.

@sebastienros sebastienros restored the sebros/optimize branch December 2, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant