Don't find hidden property instead of the hiding property #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `TypeResolver:TryFindMemberAccessor` resolves a property, it might find one that was hidden where the non-hidden one would normally be found by C++ member access.
For example, when you access the `A` member from JavaScript, you may get the hidden one (I say "may" because `Type:GetProperties` does not specify an order in a number of versions of .NET supported by jint).
```
class Foo
{
public int A {get;set;}
public string B {get;set;}
}
class Bar : Foo
{
public new float A { get; set; }
}
```
([This dotnet fiddle](http://dotnetfiddle.net/NQRXIJ) shows that both `A` elements are iterated by `GetProperties` even though if `b` is a `Bar`, `b.A` unambiguously refers to `Bar:A`)
This change ensures that in the case where a property in a derived class hides another, the derived one is resolved to.
lahma
requested changes
Sep 4, 2024
…over property it hides sebastienros#1962
Thanks, Lahma. I've added a test and confirmed that it fails without the PR (dotnet462 windows) and passes with it. |
|
Thanks, @lahma! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1962
When
TypeResolver:TryFindMemberAccessorresolves a property, it might find one that was hidden where the non-hidden one would normally be found by C++ member access.For example, when you access the
Amember from JavaScript, you may get the hidden one (I say "may" becauseType:GetPropertiesdoes not specify an order in a number of versions of .NET supported by jint).(This dotnet fiddle shows that both
Aelements are iterated byGetPropertieseven though ifbis aBar,b.Aunambiguously refers toBar:A)This change ensures that in the case where a property in a derived class hides another, the derived one is resolved to.