Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ExpressionHelper.TextSpan_ToString to prevent multiple copies at NumberLiteralBase<T> #167

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Added ExpressionHelper.TextSpan_ToString to prevent multiple copies at NumberLiteralBase<T> #167

merged 3 commits into from
Nov 20, 2024

Conversation

gumbarros
Copy link
Contributor

sebastienros
sebastienros reviewed Nov 20, 2024
View reviewed changes
Copy link
Owner

@sebastienros sebastienros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the unnecessary number.ToString might have a significant impact. Including in ncalc. Will re run the benchmarks after that.

src/Parlot/Compilation/ExpressionHelper.cs Outdated Show resolved Hide resolved
@sebastienros sebastienros merged commit 3bab85f into sebastienros:main Nov 20, 2024
1 check passed
@sebastienros
Copy link
Owner

Benchmarked it an the improvement is visible on net6.0, non-compiled (where the tostring() was used).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gumbarros @sebastienros