Ad central package management #97
Conversation
| <PackageVersion Include="Newtonsoft.Json" Version="13.0.3" /> | ||
|
|
||
| <!-- Global Package References --> | ||
| <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="all" /> |
There was a problem hiding this comment.
PrivateAssets="all" probably has no effect here
There was a problem hiding this comment.
"here", do you mean because Microsoft.SourceLink.GitHub doesn't need it? GlobalPackageReference actually maintains it, had to learn since you taught me that it didn't have any effect in the PackageVersion tags. https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management#global-package-references
There was a problem hiding this comment.
And double-checked, SourceLink requires the PrivateAssets attribute (was obvious)
There was a problem hiding this comment.
Well from Jint's viewpoint...
Deps in Packages.props:
No deps on actual artifact:
There was a problem hiding this comment.
I think I found the explanation:
Source Link package is a development dependency, which means it is only used during build. It is therefore recommended to set PrivateAssets to all on the package reference. This prevents consuming projects of your nuget package from attempting to install Source Link.
Referencing any Source Link package in a .NET SDK 8+ project suppresses Source Link that is included in the SDK.
There was a problem hiding this comment.
Yes, generally any <GlobalPackageReference> is kind of a fire-and-forget, it won't/shouldn't be present in actual package
There was a problem hiding this comment.
A reason I like to have them in a separate <ItemGroup> as they behave differently
There was a problem hiding this comment.
Keeping it, for safety
There was a problem hiding this comment.
Like you said. I asked internally to understand how it's done and what is the recommendation.
There was a problem hiding this comment.
I only understand your comment now, fixing ...
No description provided.