Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in
Cargo.toml
memchr
can have no default features.log
,serde_json
,tempfile
) to dev-dependencies.Related changes about function only covered in tests are not done yet.
Questions about deps and more changes
I found most macros are not necessary for this serde of yml. Could they be just removed, added feature flags, or moved to another crate?
macro_directory
,macro_file
,macro_get_field
: Could be moved to a utility crate, as they depend on filesystem and different serde formats. Besides, theNot Found
error message checking in tests can fail where it is not given in English.macro_nested_enum_serde
. Just a one-line shorthand.macro_replace_placeholder
. It does nothing with yml. Just a string utility.macro_from_number
. It may be replaced by a blanket impl:macro_partialeq_numeric
does more, but it does not need to be exported either.crate::utilities::directory
is only referer in fs related tests. It should belong to a fs utility crate.dep::tempfile
anddep:log
go with it.serde_yml::modules::path::Path
derivesSerialize
only because a test need it. If this derive is stripped,dep:serde
can have no extra feature enabled.anyhow
only appears in docs.serde_yml::Result<()>
is adequate here.serde_json
is a dependency in a yml library.A radical patch can be found in https://github.com/QuadnucYard/serde_yml/tree/relex-deps-radical. I do not include it here.
btw, could you open the issues channel?