Segment exploring capability #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 26, 2014 20:58
Also integrated into sample app but its rough
The existing decode method (decodePolyline:encodedPoints) crashes with certain segments. New decode method couples Map to MapKit as it returns a MKPolyline but seems to work with the segment that was causing crashing.
Also removed filtering by category as this appears to be non functional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across your excellent Strava V3 library for a pet project and as luck would have it the segment explorer API I was after was one of the few that wasn't supported.
I added a new API call on FRDStravaClient+Segment : fetchSegmentsWithRegion:activityType:success:failure
I also added a basic explorer into the sample app.
A couple of things to note:
I used a MKCoordinateRegion to specify the bouncing box for the desired segments. This does introduce a dependancy on MapKit but I couldn't think of any better data structure which wouldn't cause confusion?
I had trouble with the decodePolyline method on StravaMap which would crash due to an out of bounds issue.
I introduced a broadly duplicate method that returns an MKPolyline which appears to not have the same issue.