feat(Event): Make organizer.email optional

Closes #137
sebbo2002 · Mar 23, 2021 · 8450492 · 8450492
1 parent 3f9ae02
commit 8450492
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 11 deletions.
diff --git a/src/event.ts b/src/event.ts
@@ -994,10 +994,14 @@ export default class ICalEvent {
         // ORGANIZER
         if (this.data.organizer) {
             g += 'ORGANIZER;CN="' + escape(this.data.organizer.name) + '"';
+
             if (this.data.organizer.email && this.data.organizer.mailto) {
                 g += ';EMAIL=' + escape(this.data.organizer.email);
             }
-            g += ':mailto:' + escape(this.data.organizer.mailto || this.data.organizer.email) + '\r\n';
+            if(this.data.organizer.email) {
+                g += ':mailto:' + escape(this.data.organizer.mailto || this.data.organizer.email);
+            }
+            g += '\r\n';
         }
 
         // ATTENDEES

diff --git a/src/tools.ts b/src/tools.ts
@@ -236,10 +236,7 @@ export function checkNameAndMail (attribute: string, value: string | ICalOrganiz
     }
 
     if (!result.name) {
-        throw new Error('`organizer.name` is empty!');
-    }
-    if (!result.email) {
-        throw new Error('`organizer.email` is empty!');
+        throw new Error('`' + attribute + '.name` is empty!');
     }
 
     return result;

diff --git a/src/types.ts b/src/types.ts
@@ -33,7 +33,7 @@ export interface ICalGeo {
 
 export interface ICalOrganizer {
     name: string;
-    email: string;
+    email?: string;
     mailto?: string;
 }
 

diff --git a/test/event.ts b/test/event.ts
@@ -1197,11 +1197,6 @@ describe('ical-generator Event', function () {
 
         it('should throw error when object misses data', function () {
             const e = new ICalEvent({}, new ICalCalendar());
-            assert.throws(function () {
-                // @ts-ignore
-                e.organizer({name: 'Sebastian Pekarek'});
-            }, /`organizer\.email`/);
-
             assert.throws(function () {
                 // @ts-ignore
                 e.organizer({email: 'foo'});
@@ -1219,6 +1214,20 @@ describe('ical-generator Event', function () {
                 e.organizer(NaN);
             }, /`organizer`/);
         });
+
+        it('should work without an email', function () {
+            const event = new ICalEvent({
+                start: moment(),
+                summary: 'Example Event'
+            }, new ICalCalendar());
+
+            event.organizer({name: 'Sebastian Pekarek'});
+            assert.deepStrictEqual(event.organizer(), {
+                name: 'Sebastian Pekarek',
+                email: undefined,
+                mailto: undefined
+            });
+        });
     });
 
     describe('createAttendee()', function () {