require('ical-generator') without '.default' #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overwriting module.exports with Object.assign makes `const ical = require('ical-generator')` fully functional in js.
No need for '.default' anymore.
|
Uh, that's a nice one, thank you. I'll add a test to pass the code coverage check and merge it, thank you very much! ❤️ |
sebbo2002
added a commit
that referenced
this pull request
May 12, 2021
Merged
github-actions bot
pushed a commit
that referenced
this pull request
May 12, 2021
# [2.1.0-develop.4](v2.1.0-develop.3...v2.1.0-develop.4) (2021-05-12) ### Features * Allow use of `require('ical-generator')` without `.default` ([31833a6](31833a6)), closes [#253](#253)
|
🎉 This PR is included in version 2.1.0-develop.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Nice! Thanks for the quick reaction! Glad it is helpful :) |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sebbo2002
added a commit
that referenced
this pull request
Mar 17, 2023
BREAKING CHANGE: Importing the generator with `const ical = require('ical-generator');` (introduced with 2.1.0 / #253) will not work anymore, please use `const { default: ical } = require('ical-generator');` or move to fancy ESM imports (`import ical from 'ical-generator' ;`).
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
# [4.0.0-develop.1](v3.6.2-develop.4...v4.0.0-develop.1) (2023-03-17) ### Features * ESM Module ([7e1f07a](7e1f07a)) ### BREAKING CHANGES * Importing the generator with `const ical = require('ical-generator');` (introduced with 2.1.0 / #253) will not work anymore, please use `const { default: ical } = require('ical-generator');` or move to fancy ESM imports (`import ical from 'ical-generator' ;`).
github-actions bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
# [4.0.0](v3.6.1...v4.0.0) (2023-03-30) ### Bug Fixes * **Event:** Add `RRULE:` prefix in event.repeating() if it's not already there ([92c2034](92c2034)), closes [#459](#459) * Update escaping for quoted values ([faf5c70](faf5c70)), closes [#463](#463) ### Build System * Deprecate node.js 12 ([426588b](426588b)) * Native ESM support ([7b86a4f](7b86a4f)) ### Features * ESM Module ([7e1f07a](7e1f07a)) ### BREAKING CHANGES * Importing the generator with `const ical = require('ical-generator');` (introduced with 2.1.0 / #253) will not work anymore, please use `const { default: ical } = require('ical-generator');` or move to fancy ESM imports (`import ical from 'ical-generator' ;`). * From now on, only node.js ^14.8.0 || >=16.0.0 are supported * Only Support for node.js ^12.20.0 || >=14.13.1
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overwriting module.exports with Object.assign makes
const ical = require('ical-generator')fully functional in js.No need for '.default' anymore.
It changes nothing for typescript. It's only for Javascript, so the following isn't true anymore:
Destructured requires work the same in js and ts.
Pull Request Checklist
npm run lintto double checknpm run testto run the unit tests andnpm run coverageto generate a coverage report