Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing "RRULE:" prefix when adding repeating as string to event #459

Closed
davidruisinger opened this issue Feb 2, 2023 · 3 comments
Closed

Missing "RRULE:" prefix when adding repeating as string to event #459

davidruisinger opened this issue Feb 2, 2023 · 3 comments
Assignees
@sebbo2002
Labels
bug released on @next released

Comments

@davidruisinger
Copy link

Not sure if this is actually intended but we store rrules in our DB without RRULE: prefix. So e.g. FREQ=WEEKLY;INTERVAL=4;WKST=MO

If I now add this string to event.repeating, it is added 1to1 to the result (see here)

Instead I would expect the generated ics string to add RRULE: as a prefix before the repeating string.
@sebbo2002 sebbo2002 self-assigned this Feb 4, 2023
@sebbo2002 sebbo2002 added the bug label Feb 4, 2023
github-actions bot pushed a commit that referenced this issue Feb 5, 2023
@semantic-release-bot
chore(release): 🔖 3.6.2-develop.2 [skip ci]
94b9e19 
## [3.6.2-develop.2](v3.6.2-develop.1...v3.6.2-develop.2) (2023-02-05)

### Bug Fixes

* **Event:** Add `RRULE:` prefix in event.repeating() if it's not already there ([92c2034](92c2034)), closes [#459](#459)
@sebbo2002
Copy link
Owner

🎉 This issue has been resolved in version 3.6.2-develop.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sebbo2002
Copy link
Owner

Hey, thanks for your bug report. The feature was mainly intended to use external RRule generators. The generators I'm aware of automatically insert the RRULE: prefix. That's why I didn't come up with the idea at all. Thanks a lot.

@sebbo2002 sebbo2002 mentioned this issue Feb 7, 2023
Merged
github-actions bot pushed a commit that referenced this issue Mar 30, 2023
@semantic-release-bot
chore(release): 🔖 4.0.0 [skip ci]
9a37dbe 
# [4.0.0](v3.6.1...v4.0.0) (2023-03-30)

### Bug Fixes

* **Event:** Add `RRULE:` prefix in event.repeating() if it's not already there ([92c2034](92c2034)), closes [#459](#459)
* Update escaping for quoted values ([faf5c70](faf5c70)), closes [#463](#463)

### Build System

* Deprecate node.js 12 ([426588b](426588b))
* Native ESM support ([7b86a4f](7b86a4f))

### Features

* ESM Module ([7e1f07a](7e1f07a))

### BREAKING CHANGES

* Importing the generator with `const ical = require('ical-generator');` (introduced with 2.1.0 / #253) will not work anymore, please use `const { default: ical } = require('ical-generator');` or move to fancy ESM imports (`import ical from 'ical-generator' ;`).
* From now on, only node.js ^14.8.0 || >=16.0.0 are supported
* Only Support for node.js ^12.20.0 || >=14.13.1
@sebbo2002
Copy link
Owner

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebbo2002 sebbo2002

Labels
bug released on @next released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebbo2002 @davidruisinger