Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location formatting #314

Closed
AlexHorstkoetter opened this issue Sep 7, 2021 · 3 comments
Closed

Location formatting #314

AlexHorstkoetter opened this issue Sep 7, 2021 · 3 comments

Comments

@AlexHorstkoetter
Copy link

AlexHorstkoetter commented Sep 7, 2021

When specifying a location with a title, address, geolocation and radius the location attribute is emitted as "title" + "address".
But when specifying a location with just a title and an address, only the title is emitted and the address is swallowed.
I would have to manually concatenate title and address and pass them into title, which is not very intuitive and not documented anywhere. Is this intended behavior?
I get that all 4 parameters are needed to emit X-APPLE-STRUCTURED-LOCATION, but why would geolocation affect regular address formatting?

@sebbo2002
Copy link
Owner

I am currently on holiday and do not have a laptop with me. Therefore, I will only be able to help after my vacation, as I would also have to do some research. I hope you can wait. Thank you

@sebbo2002 sebbo2002 self-assigned this Sep 12, 2021
@sebbo2002 sebbo2002 added bug and removed question labels Sep 20, 2021
@github-actions github-actions bot mentioned this issue Sep 20, 2021
github-actions bot pushed a commit that referenced this issue Sep 20, 2021
## [3.0.1-develop.3](v3.0.1-develop.2...v3.0.1-develop.3) (2021-09-20)

### Bug Fixes

* **Event:** Append address to `LOCATION` even without `radius` / `geo` ([09ea62e](09ea62e)), closes [#314](#314)
@sebbo2002
Copy link
Owner

🎉 This issue has been resolved in version 3.0.1-develop.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Oct 1, 2021
## [3.0.1](v3.0.0...v3.0.1) (2021-10-01)

### Bug Fixes

* **Event:** Append address to `LOCATION` even without `radius` / `geo` ([09ea62e](09ea62e)), closes [#314](#314)
@sebbo2002
Copy link
Owner

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants