-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting timezone as UTC creates strange behaviour #328
Comments
Related to this, if you set UTC as a timezone for an event, the dates become 'TZID=UTC 2021blahblah'. I'm not sure if setting the TZID on an event to utc is ever valid based on this from the spec: "This parameter MUST be specified on the "DTSTART", I could be wrong, I haven't researched the issue in huge detail. |
Currently UTC is the default and therefore does not need a call to |
🎉 This issue has been resolved in version 3.1.0-develop.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
# [3.1.0](v3.0.1...v3.1.0) (2021-11-17) ### Bug Fixes * Remove Blob usage to support modern browsers ([c4e33d3](c4e33d3)), closes [#325](#325) ### Features * **Calendar:** Handle `timezone('UTC')` correctly ([c0745e5](c0745e5)), closes [#328](#328) * **event:** Add support for event class ([a227aa2](a227aa2)) * **Event:** Handle `timezone('UTC')` correctly ([781dc3d](781dc3d)), closes [#328](#328)
🎉 This issue has been resolved in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi there,
Thanks for a maintaining this great package, I've been using it for a few years. I've just upgraded to the latest version from 1.4.3.
Just a heads up, that setting the timezone to utc:
const cal = ical({ domain: "eventcalendarapp.com", name: calendarName, timezone: "UTC", method: "publish" });
Stops the DTStart and DTEnd dates from being created with a 'Z' at the end. Which if I understand correctly makes them floating times.
Removing the timezone solves the issue, and reading the readme and the code it seems if no timezone is stated then it is handled in UTC time. Just a bit strange behaviour.
Apologies for being lazy and not doing a pull request.
Thanks again for a great package.
The text was updated successfully, but these errors were encountered: