Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaping double-quote characters #377

Closed
julianh2o opened this issue Apr 20, 2022 · 4 comments
Closed

Escaping double-quote characters #377

julianh2o opened this issue Apr 20, 2022 · 4 comments
Assignees
@sebbo2002
Labels
bug released on @next released

Comments

@julianh2o
Copy link

Hey Sebbo,

Thanks for a wonderful package, this has been great for my project in working with external calendar apps.

One question, why are double quote characters being escaped (it seems like this is being done to various fields, but notably summary).

To reproduce:

calendar.createEvent({summary:'My "quoted" string'});
console.log(calendar.toString());

Is the double quote an illegal character in an ICS field? Most of the applications that I'm sending this ICS to are rendering the escape character. Eg.. My \"quoted\" string

Cheers,
Julian
@sebbo2002 sebbo2002 added the bug label Apr 25, 2022
@sebbo2002 sebbo2002 self-assigned this Apr 25, 2022
@sebbo2002
Copy link
Owner

The escape() method currently seems to escape all strings as if they were enclosed in quotes. Which of course is not the case for fields like summary or description. I'll have a look at it during the week, but I might not get around to it until the weekend. Unfortunately I can't estimate that yet.

@sebbo2002 sebbo2002 mentioned this issue Apr 27, 2022
Merged
github-actions bot pushed a commit that referenced this issue Apr 27, 2022
@semantic-release-bot
chore(release): 🔖 3.4.2-develop.2 [skip ci]
6e69b0d 
## [3.4.2-develop.2](v3.4.2-develop.1...v3.4.2-develop.2) (2022-04-27)

### Bug Fixes

* Do not escape quotes when not required ([08a4d62](08a4d62)), closes [#377](#377)
@sebbo2002
Copy link
Owner

🎉 This issue has been resolved in version 3.4.2-develop.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@julianh2o
Copy link
Author

@sebbo2002 , thanks so much! Much appreciated :D

github-actions bot pushed a commit that referenced this issue Apr 28, 2022
@semantic-release-bot
chore(release): 🔖 3.4.2 [skip ci]
fa007dc 
## [3.4.2](v3.4.1...v3.4.2) (2022-04-28)

### Bug Fixes

* Do not escape quotes when not required ([08a4d62](08a4d62)), closes [#377](#377)
@sebbo2002
Copy link
Owner

🎉 This issue has been resolved in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebbo2002 sebbo2002

Labels
bug released on @next released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julianh2o @sebbo2002