Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect typing for event.start in v3.5.0 #411

Closed
dargmuesli opened this issue Jul 27, 2022 · 3 comments
Closed

Incorrect typing for event.start in v3.5.0 #411

dargmuesli opened this issue Jul 27, 2022 · 3 comments

Comments

@dargmuesli
Copy link

Upgrading to v3.5.0 I face the linter error Type 'Moment' is missing the following properties from type 'ICalMomentTimezoneStub': tz, _isAMomentObject on event.start.
I'm using "moment": "2.29.4".

... what to do about it? Is the new stub typing incorrect or am I doing something wrong?

@sebbo2002
Copy link
Owner

Oh yeah, that's definitely an error from the stub typings. I'll take a look...

@sebbo2002 sebbo2002 self-assigned this Jul 28, 2022
@sebbo2002 sebbo2002 added the bug label Jul 28, 2022
github-actions bot pushed a commit that referenced this issue Jul 28, 2022
## [3.5.1-develop.1](v3.5.0...v3.5.1-develop.1) (2022-07-28)

### Bug Fixes

* Remove private property from moment stub ([792adb6](792adb6)), closes [#411](#411)
@sebbo2002
Copy link
Owner

🎉 This issue has been resolved in version 3.5.1-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sebbo2002 sebbo2002 mentioned this issue Jul 28, 2022
github-actions bot pushed a commit that referenced this issue Jul 28, 2022
## [3.5.1](v3.5.0...v3.5.1) (2022-07-28)

### Bug Fixes

* Remove private property from moment stub ([792adb6](792adb6)), closes [#411](#411)
@sebbo2002
Copy link
Owner

🎉 This issue has been resolved in version 3.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants