Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some tweaks #13

Merged
merged 3 commits into from
Jan 18, 2015
Merged

Make some tweaks #13

merged 3 commits into from
Jan 18, 2015

Conversation

yumminhuang
Copy link
Contributor

Thanks for providing such useful tool.

When I use your tool to backup EBS volumes, I found two problems:

  1. It's inconvenient to add a large amount of volumes by running command one by one;
  2. It's difficult to remember volume IDs. It would be better to use name tags.

To solve these problems, I modified your code:

  1. Support using tag:Name to filter volumes;
  2. Add new options --watch-file and --unwatch-file to read volumes from a configuration file.

I also add a new option --snapshots to list all snapshots for a given volume id or volume name.

I also updated README.rst and it shows how new options work.

@sebdah sebdah added this to the 0.4.x milestone Jan 16, 2015
@sebdah sebdah self-assigned this Jan 16, 2015
@sebdah
Copy link
Owner

sebdah commented Jan 16, 2015

Thanks for this PR, it looks really good. I'm gonna read it through and test it before merging it. Will post back here as soon as possible.

sebdah pushed a commit that referenced this pull request Jan 18, 2015
@sebdah sebdah merged commit b05c9bb into sebdah:master Jan 18, 2015
@sebdah
Copy link
Owner

sebdah commented Jan 18, 2015

This has now been merged and released in version 0.4.0. Thanks again for this pull request @yumminhuang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants