Add custom properties support to modals #2007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR primarily applies custom properties support to the modal component. This is done in a similar way to how popover custom properties are applied in that they are provided fallback values and set the custom property names to override but do not output the custom properties directly.
Additional Changes
modal.active
now returnsnull
instead ofundefined
if there are no active modals.focus-ring
mixin to allow passing the opacity value of the color.