Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom properties support to modals #2007

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Conversation

sebnitu
Copy link
Owner

@sebnitu sebnitu commented Sep 5, 2024

What changed?

This PR primarily applies custom properties support to the modal component. This is done in a similar way to how popover custom properties are applied in that they are provided fallback values and set the custom property names to override but do not output the custom properties directly.

Additional Changes

  • modal.active now returns null instead of undefined if there are no active modals.
  • Refactors focus-ring mixin to allow passing the opacity value of the color.
  • Apply focus-ring to modal and remove outline variables.
  • Added focus-ring and full scale variables.
  • Apply new BEM naming function to modal component and remove prefix variables.

@sebnitu sebnitu merged commit bf154e2 into next Sep 5, 2024
2 checks passed
@sebnitu sebnitu deleted the next-modal-custom-properties branch September 5, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant