Apply dialog custom property overrides to modal and drawer components #2018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR primarily refactors how the dialog component's custom properties are used within the context of the modal and drawer components. This removes the need to apply component specific dialog styles and properties for modal and drawer and instead only pass a property map to the CSS override mixin for when default dialog styles need to be changed.
To achieve this, new
$dialog-override
maps have been added to modal and drawer components along with$inline-dialog-override
and$modal-dialog-override
for drawer to override dialog styles based on the drawer's mode. These maps are then passed tocss.override("dialog", $map...)
to help give more control over dialog styles without having to create redundant dialog properties.Additional Changes