Skip to content

Commit

Permalink
Raise minimum required Python version to 3.10
Browse files Browse the repository at this point in the history
  • Loading branch information
sebp committed Nov 13, 2024
1 parent 41a5200 commit 1545e9e
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 23 deletions.
1 change: 0 additions & 1 deletion .github/workflows/tests-workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ jobs:
fail-fast: false
matrix:
config:
- py39
- py310
- py311
- py312
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wheels-workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-22.04, windows-2019, macos-13, macos-14]
python: [39, 310, 311, 312, 313]
python: [310, 311, 312, 313]

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ this unique characteristic of such a dataset into account.
Requirements
============

- Python 3.9 or later
- Python 3.10 or later
- ecos
- joblib
- numexpr
Expand Down
2 changes: 0 additions & 2 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ image: Visual Studio 2019
environment:
# see https://www.appveyor.com/docs/build-environment/#python
matrix:
- TARGET_ARCH: "x64"
CONDA_PY: "39"
- TARGET_ARCH: "x64"
CONDA_PY: "310"
- TARGET_ARCH: "x64"
Expand Down
4 changes: 0 additions & 4 deletions ci/appveyor/py39.ps1

This file was deleted.

6 changes: 0 additions & 6 deletions ci/deps/py39.sh

This file was deleted.

2 changes: 1 addition & 1 deletion doc/install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Dependencies

The current minimum dependencies to run scikit-survival are:

- Python 3.9 or later
- Python 3.10 or later
- ecos
- joblib
- numexpr
Expand Down
8 changes: 4 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ authors = [
{name = "Sebastian Pölsterl", email = "sebp@k-d-w.org"}
]
license = {file = "COPYING"}
requires-python = ">=3.9"
requires-python = ">=3.10"
classifiers = [
"Development Status :: 4 - Beta",
"Intended Audience :: Science/Research",
Expand All @@ -36,10 +36,10 @@ classifiers = [
"Programming Language :: Cython",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Topic :: Software Development",
"Topic :: Scientific/Engineering"
]
Expand Down Expand Up @@ -113,7 +113,7 @@ namespaces = false
[tool.black]
line-length = 120
extend-exclude = "sksurv/linear_model/src/eigen"
target-version = ["py39"]
target-version = ["py310"]

[tool.pytest.ini_options]
minversion = "6.0"
Expand Down Expand Up @@ -182,7 +182,7 @@ extend-exclude = [
# Group violations by containing file.
output-format = "grouped"
line-length = 120
target-version = "py39"
target-version = "py310"

[tool.ruff.lint]
ignore = ["C408"]
Expand Down
5 changes: 2 additions & 3 deletions tests/test_coxnet.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from dataclasses import dataclass
from os.path import dirname, join
from typing import Optional

import numpy as np
from numpy.testing import assert_array_almost_equal
Expand Down Expand Up @@ -68,8 +67,8 @@ def assert_predictions_equal(coxnet, x, expected_pred):
class CoxnetExpectation:
alphas: np.ndarray
coef: pd.DataFrame
pred: Optional[np.ndarray] = None
dev: Optional[np.ndarray] = None
pred: None | np.ndarray = None
dev: None | np.ndarray = None


class CoxnetCases(FixtureParameterFactory):
Expand Down

0 comments on commit 1545e9e

Please sign in to comment.