p0f rewritten #1923
Closed
p0f rewritten #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hissssst
commented
Mar 21, 2019
•
hissssst
commented
- It is currently written in python3, but I will definetely rewrite it in six
- It's not much, because I don't want to find out that something went wrong in the beginning after writing many lines of code
- There are some comments for the reviewer. They will be definetely rewritten in the later versions of this file
gpotter2
reviewed
Mar 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #1923 +/- ##
===========================================
- Coverage 85.89% 63.24% -22.65%
===========================================
Files 187 126 -61
Lines 42746 30506 -12240
===========================================
- Hits 36716 19295 -17421
- Misses 6030 11211 +5181
|
p-l-
reviewed
Sep 17, 2019
| Only Python 3 compatible | ||
| """ | ||
| a = line.split(splitchar)[:n] | ||
| yield from a |
There was a problem hiding this comment.
Suggested change
| yield from a | |
| for elt in a: | |
| yield elt |
| """ | ||
| a = line.split(splitchar)[:n] | ||
| yield from a | ||
| yield from [default] * (n - len(a)) |
There was a problem hiding this comment.
Suggested change
| yield from [default] * (n - len(a)) | |
| for _ in range(n - len(a)): | |
| yield default |
| def lparse(line, n, default='', splitchar=':'): | ||
| """ | ||
| Function for nice parcing of 'a:b:c:d:e' lines | ||
| Only Python 3 compatible |
There was a problem hiding this comment.
Suggested change
| Only Python 3 compatible |
| gen = p0fdb.tcp_correl(direction, p0f_out, olayout, quirks) | ||
| return max(list(gen), key=lambda x: sum(x[0]))[1] | ||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
I think this should go in a separate .uts file rather than here.
|
I added a reference to this PR in #399 and I am closing it due to no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.