Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix PyPy39 tests #3924

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Try to fix PyPy39 tests #3924

merged 4 commits into from
Mar 9, 2023

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Mar 5, 2023

  • try to understand why tests fail on pypy39

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #3924 (46744bb) into master (378be02) will decrease coverage by 5.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3924      +/-   ##
==========================================
- Coverage   86.96%   81.74%   -5.22%     
==========================================
  Files         310      327      +17     
  Lines       70619    74712    +4093     
==========================================
- Hits        61417    61077     -340     
- Misses       9202    13635    +4433     

see 45 files with indirect coverage changes

@evverx
Copy link
Contributor

evverx commented Mar 7, 2023

Judging by #3927 669506b seems to be the culprit. With that commit reverted the test suite no longer times out with PyPy. I haven't figured out what exactly caused the regression yet though.

@gpotter2 gpotter2 force-pushed the fix-pypy39-tests branch 2 times, most recently from 79f1ca2 to a00fc61 Compare March 9, 2023 13:19
@gpotter2 gpotter2 changed the title Add ~scanner until the tests work Try to fix PyPy39 tests Mar 9, 2023
@gpotter2
Copy link
Member Author

gpotter2 commented Mar 9, 2023

Nice catch @evverx. I had some suspicions but that lead me on the right track: it silently broke the config of coverage.py which actually ran coverage on.. all of Python, leading to huge perf losses & some automotive tests to crash.
see 46fde3e

@evverx
Copy link
Contributor

evverx commented Mar 9, 2023

it silently broke the config of coverage.py

Given how hard it is to spot I think it would be great if coverage complained about that. Looking at https://coverage.readthedocs.io/en/stable/config.html it seems all options always go into their own subsections.

see 46fde3e

I have to admit it didn't even occur to me to look at that part of pyproject.toml. My guess was that wheels broke something somehow.

@gpotter2 gpotter2 force-pushed the fix-pypy39-tests branch 2 times, most recently from 60e8854 to 208328b Compare March 9, 2023 17:47
@gpotter2 gpotter2 merged commit 181aa4d into secdev:master Mar 9, 2023
@gpotter2 gpotter2 deleted the fix-pypy39-tests branch March 9, 2023 20:58
@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants