Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stun packet creation #4421

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Fixed stun packet creation #4421

merged 2 commits into from
Jun 22, 2024

Conversation

gkpln3
Copy link
Contributor

@gkpln3 gkpln3 commented Jun 11, 2024

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

fixes #xxx

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (6b26ace) to head (80d1517).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4421      +/-   ##
==========================================
- Coverage   82.21%   81.56%   -0.65%     
==========================================
  Files         352      352              
  Lines       84032    84032              
==========================================
- Hits        69083    68544     -539     
- Misses      14949    15488     +539     
Files Coverage Δ
scapy/contrib/stun.py 88.46% <100.00%> (+6.41%) ⬆️

... and 23 files with indirect coverage changes

@gpotter2
Copy link
Member

Thanks for the PR. Could you add a unit test?
See the test/contribs/ folder

@gkpln3
Copy link
Contributor Author

gkpln3 commented Jun 13, 2024

Thanks for the PR. Could you add a unit test? See the test/contribs/ folder

Thanks for the comment, I've added some UT

@gpotter2 gpotter2 added the bug label Jun 22, 2024
@gpotter2 gpotter2 merged commit 160e20d into secdev:master Jun 22, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants