Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS - correct rr type 0 to be in line with RFC #4425

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

wesinator
Copy link
Contributor

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

set DNS rr type 0 label to "RESERVED", per latest IANA + RFC
https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#dns-parameters-4

see #4416 (comment)

set dns rr type `0` label to "RESERVED", per latest IANA + RFC
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (b4bf3d6) to head (bad7ca5).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4425      +/-   ##
==========================================
- Coverage   81.57%   81.56%   -0.01%     
==========================================
  Files         352      352              
  Lines       84016    84032      +16     
==========================================
+ Hits        68532    68537       +5     
- Misses      15484    15495      +11     
Files Coverage Δ
scapy/layers/dns.py 87.63% <ø> (ø)

... and 9 files with indirect coverage changes

@gpotter2
Copy link
Member

@guedou I think I'm okay with this PR. You decide though

@gpotter2 gpotter2 merged commit 4e94611 into secdev:master Jul 30, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants