-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various critical bugs on Windows #4467
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4467 +/- ##
==========================================
+ Coverage 81.14% 81.68% +0.53%
==========================================
Files 355 355
Lines 84643 84706 +63
==========================================
+ Hits 68687 69190 +503
+ Misses 15956 15516 -440
|
d1460fa
to
cc4263b
Compare
647c7e9
to
4753339
Compare
Note: this module should be considered a last chance only, as it comes with MANY limitations.
7791da5
to
bc071da
Compare
e07e9bc
to
6aeece6
Compare
So apparently |
0203606
to
1ced0c2
Compare
@polybassa DoIP tests don't pass on Windows, even on my machine. Do you mind having a look into that? |
0858f16
to
86fcb43
Compare
86fcb43
to
051a3bd
Compare
Note: I've ended up disabling the DoIP tests that fail on Windows. I had a partially working fix in 86fcb43, but It still slightly failed (only on Python 3.7) and I'm unsure of why. Feel free to get inspiration from that commit if necessary |
3b1b03a
to
2e6316c
Compare
This PR:
select_objects
for the SMB server to properly work on windows