Use SourceMACField in ICMPv6NDOptSrcLLAddr #4468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4468 +/- ##
==========================================
- Coverage 81.49% 81.49% -0.01%
==========================================
Files 355 355
Lines 84643 84641 -2
==========================================
- Hits 68983 68978 -5
- Misses 15660 15663 +3
|
rkinder2023
reviewed
Jul 17, 2024
| @@ -228,8 +228,6 @@ def i2h(self, pkt, x): | |||
| # type: (Optional[Packet], Optional[str]) -> str | |||
| if x is None: | |||
| iff = self.getif(pkt) | |||
| if iff is None: | |||
There was a problem hiding this comment.
This looks unrelated to the change, perhaps in a different PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conf.ifacein this case