Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDAP - test against openLDAP, minor win-proto fixes #4539

Merged
merged 8 commits into from
Sep 28, 2024
Merged

LDAP - test against openLDAP, minor win-proto fixes #4539

merged 8 commits into from
Sep 28, 2024

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Sep 27, 2024 •
edited
Loading

This PR performs various small changes against Windows protocols:

  • Kerberos:
    • fix crealm in Kerberos authenticator
    • add a function to get an account's salt in the kerberos automaton
  • LDAP:
    • add a nice lexer/parser of RFC2254's ldap search string format
    • add a search() function to ldap
    • add doc
    • test our client against OpenLDAP
      Other:
    • minor fix in DCE/RPC any() conformant field
    • some TLS tests would fail because the sockets were not closed.

@gpotter2 gpotter2 force-pushed the win-ldap branch 4 times, most recently from 7ffeb5c to d9c010e Compare September 27, 2024 23:39
@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.54305% with 95 lines in your changes missing coverage. Please review.

Project coverage is 81.62%. Comparing base (a07e5d5) to head (61f2852).

Files with missing lines Patch % Lines
scapy/layers/ldap.py 73.00% 54 Missing ⚠️
scapy/layers/kerberos.py 17.07% 34 Missing ⚠️
scapy/layers/smb2.py 88.33% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4539      +/-   ##
==========================================
+ Coverage   81.58%   81.62%   +0.04%     
==========================================
  Files         356      356              
  Lines       85274    85533     +259     
==========================================
+ Hits        69573    69819     +246     
- Misses      15701    15714      +13
Files with missing lines Coverage Δ
scapy/layers/dcerpc.py 90.99% <100.00%> (ø)
scapy/layers/smb2.py 87.28% <88.33%> (+0.03%) ⬆️
scapy/layers/kerberos.py 66.27% <17.07%> (-1.16%) ⬇️
scapy/layers/ldap.py 67.47% <73.00%> (+13.23%) ⬆️

... and 7 files with indirect coverage changes

@gpotter2 gpotter2 changed the title LDAP - test against other LDAP, minor win-proto fixes LDAP - test against openLDAP, minor win-proto fixes Sep 28, 2024
@gpotter2 gpotter2 force-pushed the win-ldap branch 2 times, most recently from a0bcbc1 to c017074 Compare September 28, 2024 12:43
@gpotter2 gpotter2 merged commit f7a6411 into secdev:master Sep 28, 2024
22 of 23 checks passed
@gpotter2 gpotter2 deleted the win-ldap branch September 28, 2024 13:11
evverx added a commit to evverx/scapy that referenced this pull request Sep 28, 2024
@evverx
ci: skip OpenLDAP tests on Packit
2ae96a6 
until I figure out whether it's possible to set up slapd there by
analogy with what the scapy action on GitHub does.

It's a follow-up to secdev#4539.
@evverx evverx mentioned this pull request Sep 28, 2024
Merged
@gpotter2
Copy link
Member Author

/packit propose-downstream

gpotter2 pushed a commit that referenced this pull request Sep 28, 2024
@evverx
ci: skip OpenLDAP tests on Packit (#4540)
41b6f2c 
until I figure out whether it's possible to set up slapd there by
analogy with what the scapy action on GitHub does.

It's a follow-up to #4539.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gpotter2