[Windows] Fixed ppi_geotag

[gpotter2]

Fixes ppi_geotag's part in #432 + added a few tests

[codecov-io]

Current coverage is 69.48% (diff: 100%)

Merging #479 into master will decrease coverage by 0.10%

@@             master       #479   diff @@
==========================================
  Files           104        106     +2   
  Lines         25622      25938   +316   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          17831      18023   +192   
- Misses         7791       7915   +124   
  Partials          0          0          

Diff Coverage	File Path
•••••••••• 100%	scapy/contrib/ppi_geotag.py

Powered by Codecov. Last update 9c8f1a7...d71e28c

[p-l-]

Could you explain why you replaced time.gmtime(0)?

[gpotter2]

It's a windows bug: time.gmtime(0) will return a tuple with the date (1970, 1, 1). But for some reasons, on windows only, the range starts at (1970,1,2)

See the error stack trace at #432

[p-l-]

@gpotter2 so maybe you could just define a global constant EPOCH = time.mktime((1970, 1, 1, 0, 0, 0, 0, 0, 0))? BTW I think the current code is wrong, because you have used 1970-1-2 as the start time, while it should be 1970-1-1.

[gpotter2]

@p-l- The windows bug: time.mktime((1970, 1, 1, 0, 0, 0, 0, 0, 0)) crash because Windows Epoch is 01/01/1970 at 00:00 but of the next day (so 01/02/1970 at 00:00)
time.mktime((1970, 1, 2, 0, 0, 0, 0, 0, 0))-86400 will do the trick i guess...

[gpotter2]

That should do the trick

[gpotter2]

@guedou Hey, on master this if failing... I don't know what has changed since the tests were performed... any ideas ?

[guedou]

@gpotter2 I have no idea =/ The patches looked good to me.

The issue might be related to PR#471 Could you have a look ?

[gpotter2]

I'll check that
@p-l CAN you have a look too, please?
https://travis-ci.org/secdev/scapy/jobs/201869982#L7615

Edit: ok i've found the bug. Not sure what created it but #515 fixes it