-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IPv6] Windows: fix IPv6 routing + Net6 #644
Conversation
Why did you close this PR ? |
My bad |
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
==========================================
+ Coverage 80.88% 80.93% +0.04%
==========================================
Files 140 140
Lines 34572 34568 -4
==========================================
+ Hits 27964 27978 +14
+ Misses 6608 6590 -18
|
Could you remove the changes related to the renaming of ipaddress, or move it to a separate commit ? Thanks. |
f2daa4f
to
9e6433d
Compare
@guedou Here's an updated version. |
Thanks. Could you also add something like the following, that initialy triggered the issue ?
|
Modified it a bit. |
a67f2f7
to
bb5b2ac
Compare
@guedou Just discovered a new bug:
Sorry if the PR suddenly became big, explanation:
I don't think this should be splitted in many PRs, as it all comes from the same bug... More over the PR is easy to understand. |
5ec712e
to
e5e3b13
Compare
b935641
to
9362d00
Compare
83d31fe
to
10fe4aa
Compare
2d97224
to
fe2ba93
Compare
It looks to me. @p-l- do you want to have another look ? |
4832e96
to
37690d4
Compare
@p-l- Hi, do you have any more comments about this one ? |
Sorry @gpotter2 can you rebase against current master? |
This will speed up the boot
In order to avoid any conflicts when the consts are changed
@p-l- Done |
This PR:
in6_getifaddr
function: replace the windows one by the Pcap APIipaddress
regex (the name was really confusing)in6_getifaddr
function ofpcapdnet.py
==> now use it when loading IPv6