Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial require implementation #843

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

maxim-productengine
Copy link
Contributor

Initial "require()" implementation based on Luau CLI to allow using modules.

indra/newview/llluamanager.cpp Outdated Show resolved Hide resolved
indra/newview/llluamanager.cpp Outdated Show resolved Hide resolved
indra/newview/llluamanager.cpp Outdated Show resolved Hide resolved
indra/newview/llluamanager.cpp Show resolved Hide resolved
indra/newview/llluamanager.cpp Outdated Show resolved Hide resolved
indra/newview/llluamanager.cpp Show resolved Hide resolved
indra/newview/llluamanager.cpp Show resolved Hide resolved
indra/newview/llluamanager.cpp Show resolved Hide resolved
indra/newview/llluamanager.cpp Outdated Show resolved Hide resolved
indra/newview/llluamanager.cpp Show resolved Hide resolved
Copy link
Collaborator

@nat-goodspeed nat-goodspeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some things I'd like to see...

indra/newview/llluamanager.cpp Outdated Show resolved Hide resolved
indra/newview/llluamanager.cpp Show resolved Hide resolved
indra/newview/llluamanager.cpp Show resolved Hide resolved
indra/newview/llluamanager.cpp Show resolved Hide resolved
@nat-goodspeed
Copy link
Collaborator

Hmm! std::filesystem::path is supposed to be supported by C++17, but apparently Apple didn't bother to back-port it to macOS 10.13, which we still claim as our build target.

I'll check with Product, but this looks like a pretty good reason to bump the build-variables/variables minimum macOS target.

@maxim-productengine maxim-productengine merged commit 777586a into release/luau-scripting Feb 27, 2024
8 of 11 checks passed
@maxim-productengine maxim-productengine deleted the luau-require-impl branch February 27, 2024 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants