Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Critical] Mistaking the source/dst copy in the PackedB2A implementation #811

Closed
fionser opened this issue Aug 13, 2024 · 1 comment · Fixed by #819
Closed

[Bug][Critical] Mistaking the source/dst copy in the PackedB2A implementation #811

fionser opened this issue Aug 13, 2024 · 1 comment · Fixed by #819
Assignees

Comments

@fionser
Copy link
Contributor

fionser commented Aug 13, 2024

Issue Type

Currentness/Accuracy

Modules Involved

MPC protocol

Have you reproduced the bug with SPU HEAD?

Yes

Have you searched existing issues?

Yes

SPU Version

74c6d54

OS Platform and Distribution

MacOS

Python Version

3.9

Compiler Version

No response

Current Behavior?

Basically the copying is wrong here.

https://github.com/secretflow/spu/blob/main/libspu/mpc/cheetah/ot/basic_ot_prot.cc#L133

UTs are passed due to the random masking r = 0 now which is also unsecure.

Standalone code to reproduce the issue

The 1st argument in `SseTranspose` should be the output.

Relevant log output

No response

@fionser fionser mentioned this issue Aug 13, 2024
@fionser
Copy link
Contributor Author

fionser commented Aug 13, 2024

Thank Jinjin Zhou for finding my awful mistake :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant