Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sml] add LabelBinarizer, Binarizer, Normalizer in jax #470

Merged
merged 12 commits into from
Jan 15, 2024

Conversation

winnylyc
Copy link
Contributor

Pull Request

What problem does this PR solve?

Realize Preprocessing function including LabelBinarizer, Binarizer, Normalizer in jax.

Copy link

github-actions bot commented Jan 11, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@winnylyc
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

sml/preprocessing/preprocessing.py Outdated Show resolved Hide resolved
sml/preprocessing/preprocessing.py Outdated Show resolved Hide resolved
sml/preprocessing/preprocessing.py Outdated Show resolved Hide resolved
sml/preprocessing/preprocessing.py Outdated Show resolved Hide resolved
sml/preprocessing/preprocessing.py Outdated Show resolved Hide resolved
@deadlywing
Copy link
Contributor

Hello,整体实现都非常好,上述comment有什么意见需要讨论的可以直接回复哈~

@deadlywing
Copy link
Contributor

@winnylyc 其他应该ok了~

@Candicepan Candicepan linked an issue Jan 15, 2024 that may be closed by this pull request
@winnylyc
Copy link
Contributor Author

感谢老师的指导!

@deadlywing
Copy link
Contributor

感谢老师的指导!

也感谢同学的实现和快速响应哈~
BTW,感觉同学的代码质量还是挺高的,方便了解一下研究方向或者有兴趣尝试其他task么?

@deadlywing deadlywing merged commit 1f4a468 into secretflow:main Jan 15, 2024
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在 SML 中实现预处理算法
2 participants