Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Docker support #10

Merged
merged 4 commits into from
Mar 19, 2019
Merged

Docker support #10

merged 4 commits into from
Mar 19, 2019

Conversation

florisvdg
Copy link
Member

@florisvdg florisvdg commented Mar 12, 2019

With support for passing credential as env var or to mount it as a volume.

Still needs a solution to pass in a credential passphrase. Or we could choose to not support it, because in a containerized environment, shouldn't one usually use service accounts anyway instead of personal credentials?

@florisvdg florisvdg changed the base branch from master to develop March 12, 2019 13:48
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach!

Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@florisvdg florisvdg merged commit 5423612 into develop Mar 19, 2019
@florisvdg florisvdg deleted the docker branch March 19, 2019 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants