Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Renamed to REST proxy and project split into cmd and pkg #2

Merged
merged 4 commits into from
Mar 6, 2019

Conversation

florisvdg
Copy link
Member

No description provided.

@florisvdg florisvdg changed the base branch from master to develop March 5, 2019 13:54
go.mod Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
pkg/restproxy/rest_proxy.go Show resolved Hide resolved
pkg/restproxy/rest_proxy.go Show resolved Hide resolved
pkg/restproxy/rest_proxy.go Outdated Show resolved Hide resolved
pkg/restproxy/rest_proxy.go Outdated Show resolved Hide resolved
@florisvdg
Copy link
Member Author

@SimonBarendse moving to the open source client is still to-do, but outside of the scope of this PR

@SimonBarendse
Copy link
Member

@florisvdg Oke 👍

Renaming the project in go.mod is in scope though, so I'm reopening that one.

@florisvdg florisvdg requested a review from SimonBarendse March 5, 2019 16:07
pkg/restproxy/rest_proxy.go Outdated Show resolved Hide resolved
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few tiny nonw-blocking style comments

pkg/restproxy/rest_proxy.go Outdated Show resolved Hide resolved
pkg/restproxy/rest_proxy.go Outdated Show resolved Hide resolved
pkg/restproxy/rest_proxy.go Outdated Show resolved Hide resolved
@florisvdg florisvdg merged commit 12b03e8 into develop Mar 6, 2019
@florisvdg florisvdg deleted the rest-proxy branch March 6, 2019 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants