Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Build the binary in the Dockerfile #21

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Build the binary in the Dockerfile #21

merged 3 commits into from
Apr 30, 2019

Conversation

SimonBarendse
Copy link
Member

This makes the Dockerfile stand-alone instead of depending on
goreleaser to create the binary. You can now build the image with
"go build .".

SimonBarendse and others added 2 commits April 30, 2019 10:48
@SimonBarendse
Build the binary in the Dockerfile
e9961ac 
This makes the Dockerfile stand-alone instead of depending on
goreleaser to create the binary. You can now build the image with
"go build .".
@mackenbach
Add docker build instructions to the README
81042a3
mackenbach
mackenbach approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I have one question that shouldn't be blocking. Check it out and merge when satisfied.

.goreleaser.yml Show resolved Hide resolved
@SimonBarendse SimonBarendse merged commit 8a0a440 into develop Apr 30, 2019
@SimonBarendse SimonBarendse deleted the feature/dockerfile branch April 30, 2019 09:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mackenbach mackenbach mackenbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonBarendse @mackenbach