Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Add README with installation, usage and development instructions #9

Merged
merged 24 commits into from
Apr 4, 2019

Conversation

florisvdg
Copy link
Member

Note: GitHub release and DockerHub image does not exist yet

@florisvdg florisvdg requested a review from mackenbach March 11, 2019 17:46
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, feels like it is all coming together now! I have some adjustments to make it feel a bit more complete imo. Have a look.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@florisvdg florisvdg requested a review from mackenbach March 19, 2019 16:03
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes man, really good. I have a few small comments. Feel free to merge after addressing them. I feel like we should get this merged and then keep improving it if necessary (e.g. badges and what not)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@florisvdg florisvdg changed the title Added README with installation, usage and development instructions Add README with installation, usage and development instructions Mar 29, 2019
@mackenbach
Copy link
Member

@florisvdg what's keeping this PR open? Let's implement necessary fixes and get this merged if needed.

@florisvdg florisvdg requested a review from mackenbach April 1, 2019 11:41
README.md Outdated Show resolved Hide resolved
@florisvdg florisvdg merged commit a42c3c6 into develop Apr 4, 2019
@florisvdg florisvdg deleted the readme branch April 4, 2019 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants