This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Add README with installation, usage and development instructions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackenbach
suggested changes
Mar 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, feels like it is all coming together now! I have some adjustments to make it feel a bit more complete imo. Have a look.
mackenbach
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes man, really good. I have a few small comments. Feel free to merge after addressing them. I feel like we should get this merged and then keep improving it if necessary (e.g. badges and what not)
Fancy README heading
mackenbach
reviewed
Mar 27, 2019
florisvdg
changed the title
Added README with installation, usage and development instructions
Add README with installation, usage and development instructions
Mar 29, 2019
@florisvdg what's keeping this PR open? Let's implement necessary fixes and get this merged if needed. |
mackenbach
reviewed
Apr 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: GitHub release and DockerHub image does not exist yet