This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Data source secrethub_secret #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florisvdg
commented
Feb 20, 2019
|
I also opened a feature request issue on the Terraform repo https://github.com/hashicorp/terraform/issues/20391. Maybe they have a workaround for it. |
SimonBarendse
suggested changes
Feb 20, 2019
SimonBarendse
approved these changes
Feb 22, 2019
SimonBarendse
approved these changes
Feb 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New data source
secrethub_secretto be able to use secrets that are created elsewhere.The implementation is unfortunately not ideal because it will flood the secret's audit trail due to the way Terraform reads data sources hashicorp/terraform#13044 (comment).
There are plans to change the data source lifecycle, which can be a big improvement for our use case:
hashicorp/terraform#17034.