Verify that what's being deployed looks like a Node.js app #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| errstr := strings.Join(se, "\n") | ||
| return fmt.Errorf("not a valid Node.js app: \n\n%s", errstr) | ||
| } |
There was a problem hiding this comment.
I think that we should print only one error at a time. The user will fix only one error at a time anyway.
There was a problem hiding this comment.
I originally thought this too.
On reflection, it can be frustrating being drip-fed errors.
I want to give this a try, and see what users have to say about it.
pavelnikolov
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that:
node_modules/is a directory in the target app directorypackage.jsonis a file in the target app directory