Code

Diff Scion Vault with FPS Audit#1

Code

Open

0x0scion wants to merge 120 commits intofps-auditsector-fi/rari-vaults:fps-auditfrom mainsector-fi/rari-vaults:mainCopy head branch name to clipboard

+2,342-1,168

Commits

Commits on Nov 8, 2021

• 📝 More comments

  transmissions11

  committed
  edd6347

  Copy full SHA for edd6347

• 👷‍♂️ Lower optimizer runs

  transmissions11

  committed
  421ceeb

  Copy full SHA for 421ceeb

• 📝 Comment fixes

  transmissions11

  committed
  14a0a8c

  Copy full SHA for 14a0a8c

Commits on Nov 9, 2021

• ♻️ Remove VaultFactory import

  transmissions11

  committed
  3ce535e

  Copy full SHA for 3ce535e

Commits on Nov 10, 2021

• ♻️ Cleanup tests

  transmissions11

  committed
  3e2958f

  Copy full SHA for 3e2958f

• ✨ VaultRouterModule

  transmissions11

  committed
  a35ecf1

  Copy full SHA for a35ecf1

• 🐛 Missing equal sign

  transmissions11

  committed
  031c776

  Copy full SHA for 031c776

• ♻️ Reorder and make vars public in VaultConfigurationModule

  transmissions11

  committed
  0d8fe9d

  Copy full SHA for 0d8fe9d

• 🔊 Add event to VaultCreationModule

  transmissions11

  committed
  6f8cff7

  Copy full SHA for 6f8cff7

• 📝 Comment on cast overflow

  transmissions11

  committed
  202381a

  Copy full SHA for 202381a

• 🐛 Seize strategy operator flip

  transmissions11

  committed
  64a47ac

  Copy full SHA for 64a47ac

Commits on Nov 11, 2021

• 🔒 Add requireAuth to more queue funcs

  transmissions11

  committed
  a44f067

  Copy full SHA for a44f067

• 🔒 Pop untrusted and depleted strats from queue

  transmissions11

  committed
  ba8c5a3

  Copy full SHA for ba8c5a3

• ⚡️ Unchecked and cast optimizations

  transmissions11

  committed
  fdb9242

  Copy full SHA for fdb9242

• 👷‍♂️ Update optimize runs

  transmissions11

  committed
  38baae1

  Copy full SHA for 38baae1

• 📝 Comment fix

  transmissions11

  committed
  895f081

  Copy full SHA for 895f081

• dapp upgrade solmate

  transmissions11

  committed
  9735fde

  Copy full SHA for 9735fde

Commits on Nov 12, 2021

• ✅ More tests & assorted fixes

  transmissions11

  committed
  3e10da8

  Copy full SHA for 3e10da8

• dapp upgrade solmate

  transmissions11

  committed
  da2178c

  Copy full SHA for da2178c

• ♻️ Upgrade to solc 0.8.10

  transmissions11

  committed
  74364d2

  Copy full SHA for 74364d2

• 👷‍♂️ Upgrade dapptools

  transmissions11

  committed
  f33cfb9

  Copy full SHA for f33cfb9

• dapp upgrade solmate

  transmissions11

  committed
  27dbbe6

  Copy full SHA for 27dbbe6

• ✅ Basic integration tests

  transmissions11

  committed
  80f6a5f

  Copy full SHA for 80f6a5f

Commits on Nov 14, 2021

• 🚧 Batch harvest

  transmissions11

  committed
  53ba195

  Copy full SHA for 53ba195

• 📝 Comment fixes

  transmissions11

  committed
  0152a2f

  Copy full SHA for 0152a2f

Commits on Nov 15, 2021

• 🐛 Use lockedProfit() to update maxLockedProfit

  transmissions11

  committed
  ba3e59f

  Copy full SHA for ba3e59f

• ✅ Test exchange rate remains constant during multi harvests

  transmissions11

  committed
  b813e71

  Copy full SHA for b813e71

• ♻️ fvToken -> rvToken

  transmissions11

  committed
  d0610cd

  Copy full SHA for d0610cd

• 📝 Typos

  transmissions11

  committed
  5bfaca1

  Copy full SHA for 5bfaca1

• 📝 Comment fix

  transmissions11

  authored
  740a298

  Copy full SHA for 740a298

• 📝 Better comment

  transmissions11

  authored
  8c5b427

  Copy full SHA for 8c5b427

• ♻️ Rename

  transmissions11

  committed
  65e59fa

  Copy full SHA for 65e59fa

• 🔥 Remove TODO

  transmissions11

  committed
  85e0fa1

  Copy full SHA for 85e0fa1

• 📝 Comment fix

  transmissions11

  committed
  f84d6d4

  Copy full SHA for f84d6d4

Commits on Nov 16, 2021

• 👷‍♂️ Upgrade DappTools

  transmissions11

  authored
  2f04e2e

  Copy full SHA for 2f04e2e

• 📝 Clear up use of underflow/overflow

  transmissions11

  authored
  609a1c5

  Copy full SHA for 609a1c5

Commits on Nov 18, 2021

• ♻️ Naming and comment fixes

  transmissions11

  committed
  a62f4e1

  Copy full SHA for a62f4e1

• 🔒 Creation -> Initialization Module

  transmissions11

  committed
  650c7a2

  Copy full SHA for 650c7a2

• 📝 Comment fixes

  transmissions11

  committed
  edcc8a2

  Copy full SHA for edcc8a2

• dapp upgrade solmate

  transmissions11

  committed
  1c697e0

  Copy full SHA for 1c697e0

• 📝 Normalize tenses

  transmissions11

  committed
  cb36bba

  Copy full SHA for cb36bba

Commits on Nov 19, 2021

• 🔥 Unused lib binding

  transmissions11

  committed
  5133668

  Copy full SHA for 5133668

• 🔊 Index WithdrawalQueueIndexReplacedWithTip field

  transmissions11

  committed
  575cbda

  Copy full SHA for 575cbda

• dapp upgrade solmate

  transmissions11

  committed
  53fa979

  Copy full SHA for 53fa979

• 👷‍♂️ Update vscode settings

  transmissions11

  committed
  7ce2a21

  Copy full SHA for 7ce2a21

• dapp upgrade solmate

  transmissions11

  committed
  c0136ff

  Copy full SHA for c0136ff

• 👷‍♂️ Update snapshots

  transmissions11

  committed
  aba1ca0

  Copy full SHA for aba1ca0

Commits on Nov 21, 2021

• 📝 Typo

  transmissions11

  committed
  6eb7afb

  Copy full SHA for 6eb7afb

Commits on Nov 22, 2021

• 🍱 Initial audits

  transmissions11

  committed
  0914ad6

  Copy full SHA for 0914ad6

• 📝 Update contributing section

  transmissions11

  authored
  a1f5787

  Copy full SHA for a1f5787

• 📝 Contributing updates

  transmissions11

  authored
  3d92dbb

  Copy full SHA for 3d92dbb

• 📝 Cleanup docs

  transmissions11

  committed
  dd32bfc

  Copy full SHA for dd32bfc

• 📝 Update architecture

  transmissions11

  committed
  17e416f

  Copy full SHA for 17e416f

• 📝 Simplify tagline

  transmissions11

  committed
  b44eeae

  Copy full SHA for b44eeae

Commits on Nov 23, 2021

• 📝 Missing comments

  transmissions11

  committed
  49cb54a

  Copy full SHA for 49cb54a

• 📝 Fix broken link

  transmissions11

  authored
  6a86710

  Copy full SHA for 6a86710

Commits on Nov 24, 2021

• 📝 Comment fixes

  transmissions11

  committed
  3153dbe

  Copy full SHA for 3153dbe

• dapp upgrade solmate

  transmissions11

  committed
  0872738

  Copy full SHA for 0872738

• dapp upgrade solmate

  transmissions11

  committed
  8cb90f6

  Copy full SHA for 8cb90f6

• 🐛 safeCastTo224 -> safeCastTo248

  transmissions11

  committed
  78e2a7d

  Copy full SHA for 78e2a7d

Commits on Nov 27, 2021

• 🔊 User field for more events

  transmissions11

  committed
  fc36e3b

  Copy full SHA for fc36e3b

• 🔊 User field for strategy trust

  transmissions11

  committed
  6691962

  Copy full SHA for 6691962

• 🔥 Remove stale comment

  transmissions11

  committed
  2bb04b6

  Copy full SHA for 2bb04b6

• 🔊 Single event per harvest

  transmissions11

  committed
  eb18d7a

  Copy full SHA for eb18d7a

Commits on Nov 29, 2021

• 👷‍♂️ Use = instead of ==

  transmissions11

  committed
  9eb5915

  Copy full SHA for 9eb5915

• 👷‍♂️ Check gas snapshots

  transmissions11

  committed
  1a3028e

  Copy full SHA for 1a3028e

• ⚡️ Unchecked optimization

  transmissions11

  committed
  77714d8

  Copy full SHA for 77714d8

Commits on Nov 30, 2021

• 🔒 Require auth to harvest

  transmissions11

  committed
  32f5f43

  Copy full SHA for 32f5f43

• ✨ Self destruct

  transmissions11

  committed
  887e434

  Copy full SHA for 887e434

• 👷‍♂️ More optimizer runs

  transmissions11

  committed
  33e0bef

  Copy full SHA for 33e0bef

• ✅ Test self destruct

  transmissions11

  committed
  60bbb6a

  Copy full SHA for 60bbb6a

• 💥 Add public capabilities and remove root

  transmissions11

  committed
  5238361

  Copy full SHA for 5238361

• dapp upgrade solmate

  transmissions11

  committed
  ce998ce

  Copy full SHA for ce998ce

• ♻️ Punctuation fix

  transmissions11

  committed
  057ed8b

  Copy full SHA for 057ed8b

Commits on Dec 3, 2021

• 📝 Fix misleading comment

  transmissions11

  authored
  79d62d5

  Copy full SHA for 79d62d5

Commits on Dec 11, 2021

• ✅ isVaultDeployed test

  transmissions11

  committed
  0d57d65

  Copy full SHA for 0d57d65

Commits on Dec 24, 2021

• 🔒 Fix set target float percent check (Rari-Capital#100)

  refcell

  authored
  ebf8301

  Copy full SHA for ebf8301

Commits on Jan 17, 2022

• ♻️ Only approve min in router

  transmissions11

  committed
  9f227ea

  Copy full SHA for 9f227ea

• ♻️ Internal BASE_UNIT

  transmissions11

  committed
  b9a57c1

  Copy full SHA for b9a57c1

• 🔒 [QSP-5] Prevent duplicate syncing (Rari-Capital#105)

  transmissions11

  authored
  993ae52

  Copy full SHA for 993ae52

• 📝 [QSP-2] Direct to Vault for config bounds (Rari-Capital#106)

  transmissions11

  authored
  b3150ed

  Copy full SHA for b3150ed

• ♻️ [QSP-BestPractices] Rename withdrawalQueue to withdrawalStack (Rari-Capital#107)

  transmissions11

  authored
  021fb61

  Copy full SHA for 021fb61

• 🔒 Cap withdrawal stack size

  transmissions11

  committed
  9741db8

  Copy full SHA for 9741db8

• 🔥 Remove amount != 0 checks

  transmissions11

  committed
  4d8d801

  Copy full SHA for 4d8d801

• dapp upgrade solmate

  transmissions11

  committed
  6136d0e

  Copy full SHA for 6136d0e

• 🔥 Remove VaultAuthorityModule

  transmissions11

  committed
  fb3530a

  Copy full SHA for fb3530a

• 📝 Update diagram

  transmissions11

  committed
  ed2e566

  Copy full SHA for ed2e566

• 💥 Allow seizing untrusted strats

  transmissions11

  committed
  31ee7b6

  Copy full SHA for 31ee7b6

• ♻️ Only check decimal match if newUnderlyingIsWETH is true

  transmissions11

  committed
  ba0317b

  Copy full SHA for ba0317b

Commits on Jan 19, 2022

• 🍱 Add Quantstamp report

  transmissions11

  committed
  2edd5eb

  Copy full SHA for 2edd5eb

Commits on Mar 5, 2022

• ♻️ Upgrade solmate

  JetJadeja

  committed
  adadf27

  Copy full SHA for adadf27

• ♻️ Use updated solmate fixedpointmath

  JetJadeja

  committed
  30068df

  Copy full SHA for 30068df

Commits on Mar 6, 2022

• ♻️ Gas snapshot

  JetJadeja

  committed
  2b8bb26

  Copy full SHA for 2b8bb26

• Merge pull request Rari-Capital#116 from Rari-Capital/fixes

  Show description for 113727d
  JetJadeja

  authored
  113727d

  Copy full SHA for 113727d

• 🎨 Update import structure

  JetJadeja

  committed
  c2458cd

  Copy full SHA for c2458cd

Commits on Mar 17, 2022

• Inherit from ERC4626

  JetJadeja

  committed
  0263bc9

  Copy full SHA for 0263bc9

Commits on Mar 18, 2022

• Implement deposit/withdrawal hooks

  JetJadeja

  committed
  b219520

  Copy full SHA for b219520

• Fix Vault test compilation errors

  JetJadeja

  committed
  f78e8fb

  Copy full SHA for f78e8fb

• Fix compilation errors in Integration tests

  JetJadeja

  committed
  e7fef16

  Copy full SHA for e7fef16

• Fix Vault router module

  JetJadeja

  committed
  deccaff

  Copy full SHA for deccaff

Commits on Apr 4, 2022

• forge install: forge-std

  JetJadeja

  committed
  6a26f35

  Copy full SHA for 6a26f35

• Add foundry configuration

  JetJadeja

  committed
  a93f805

  Copy full SHA for a93f805

• Implement deposit/withdraw/redeem fuzz tests

  JetJadeja

  committed
  4de54ad

  Copy full SHA for 4de54ad

• Fuzzify deposit/withdraw/redeem sanity tests

  JetJadeja

  committed
  5f58576

  Copy full SHA for 5f58576

Commits on Apr 6, 2022

• Fix testFailWithdrawWithNoBalance non-revert case

  JetJadeja

  committed
  9df3554

  Copy full SHA for 9df3554

Commits on Apr 7, 2022

• Update strategy enter/exit tests

  JetJadeja

  committed
  fb38617

  Copy full SHA for fb38617

Commits on Apr 11, 2022

• Remove assertions from enter/exit single pool test

  JetJadeja

  committed
  bfbc855

  Copy full SHA for bfbc855

Commits on Apr 12, 2022

• Update VSCode compiler verison

  JetJadeja

  committed
  6649cd9

  Copy full SHA for 6649cd9

• Enabled prettier

  JetJadeja

  committed
  46ad267

  Copy full SHA for 46ad267

• Enable fuzzing for strategy tests

  JetJadeja

  committed
  c727b4b

  Copy full SHA for c727b4b

• Enable fuzzing on strategy sanity check tests

  JetJadeja

  committed
  883ea49

  Copy full SHA for 883ea49

Commits on Apr 13, 2022

• Fix incorrect balance math bug

  JetJadeja

  committed
  b120dd8

  Copy full SHA for b120dd8

• MockStrategy should return total underlying balance

  JetJadeja

  committed
  98dfdf8

  Copy full SHA for 98dfdf8

Commits on Apr 14, 2022

• Remove irrelevant functions

  JetJadeja

  committed
  9766f8b

  Copy full SHA for 9766f8b

• Replace balanceOfUnderlying with 4626 covertToAssets

  JetJadeja

  committed
  5338bc7

  Copy full SHA for 5338bc7

Commits on Apr 16, 2022

• Fix profitable harvest test

  JetJadeja

  committed
  e60f219

  Copy full SHA for e60f219

Commits on Apr 17, 2022

• Update max delta on harvest exchange rate test

  JetJadeja

  committed
  2a3013c

  Copy full SHA for 2a3013c

• Remove assertions from harvest test

  JetJadeja

  committed
  03f1ab8

  Copy full SHA for 03f1ab8

• Eliminate unused parameter warnings

  JetJadeja

  committed
  36d6bcf

  Copy full SHA for 36d6bcf

• Fix profitable harvest test

  JetJadeja

  committed
  b611d6b

  Copy full SHA for b611d6b