Use Signer interface in EnvelopeSigner #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't need a Verifier to sign. Also remove unused threshold parameter.
adityasaky
reviewed
Sep 26, 2023
mnm678
approved these changes
Sep 26, 2023
adityasaky
approved these changes
Sep 26, 2023
|
Thanks! |
tri-adam
added a commit
to sylabs/sif
that referenced
this pull request
Dec 20, 2023
dsse.NewEnvelopeSigner now expects a Signer rather than a SignerVerifier. Trim down dsseSigner type to implement only the Signer interface. Ref: secure-systems-lab/go-securesystemslib#57
DrDaveD
pushed a commit
to apptainer/sif
that referenced
this pull request
Dec 21, 2023
dsse.NewEnvelopeSigner now expects a Signer rather than a SignerVerifier. Trim down dsseSigner type to implement only the Signer interface. Ref: secure-systems-lab/go-securesystemslib#57 Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't need a Verifier to sign. Also remove unused threshold parameter.