Prepare Debian downstream release 0.18.0-1 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lukpueh
commented
Dec 10, 2020
lukpueh
commented
- Add changelog entry
- Remove obsolete build dep in d/control
- Bump standard version and compat level in d/control
- Update d/upstream/signing-key.asc
* Add changelog entry
* Remove obsolete build dep in d/control
* Bump standard version and compat level in d/control
* Update d/upstream/signing-key.asc
gpg --armor --export --export-options export-minimal,export-clean\
8BA69B87D43BE294F23E812089A2AD3C07D962E8
1 similar comment
joshuagl
approved these changes
Dec 11, 2020
| * Update d/control to: | ||
| - remove obsolete python-dateutil dependency, | ||
| - bump standards version to 4.5.1, | ||
| - and compat to 13. |
There was a problem hiding this comment.
Nit:
Suggested change
| - and compat to 13. | |
| - increase compat to 13. |
or bump?
There was a problem hiding this comment.
Oh, I only saw this just now. I had conceived this as a sentence, that is ...
Update d/control to remove obsolete python-dateutil dependency, bump standards version to 4.5.1, and compat to 13.
But then I'd maybe have to change the punctuation?
Anyways, given that 0.18.0-1 is already released, I I'll make use of my non-native-speaker bonus and leave this as is. :P
But thanks for the thorough review, @joshuagl!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.